Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cleanup api logging (DSP-1076) #46

Merged
merged 19 commits into from Feb 10, 2021
Merged

Conversation

lrosenth
Copy link
Contributor

@lrosenth lrosenth commented Feb 8, 2021

Some cleanup of lgging of API errors
Some small fixes for the rosetta project

Afterwards acceptance a new version for Pypi will be created...

Copy link
Collaborator

@subotic subotic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are two CI errors that need to be fixed first. You can run the same tests locally with running make test.

@subotic subotic changed the title Wip/dsp 1076 cleanup api logging fix: cleanup api logging (DSP-1076) Feb 9, 2021
@lrosenth
Copy link
Contributor Author

OK, test run through. rosetta is supported.... Let's fetz -- eh -- merge

@subotic subotic merged commit d48e704 into main Feb 10, 2021
@subotic subotic deleted the wip/DSP-1076-cleanup-api-logging branch February 10, 2021 08:57
@subotic
Copy link
Collaborator

subotic commented Feb 10, 2021

@lrosenth thanks, I've merged it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants