Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: improve documentation of DSP permission system (DEV-1561) #270

Merged
merged 4 commits into from Dec 20, 2022

Conversation

jnussbaum
Copy link
Collaborator

resolves DEV-1561

@jnussbaum jnussbaum self-assigned this Dec 13, 2022
Copy link

@irinaschubert irinaschubert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just some minor remarks.

Comment on lines 178 to 213
### Groups

(optional)

`"groups": [<group-definition>, <group-definition>,...]`

The `groups` object contains **project specific** group definitions. As opposed to the
[**built-in** groups](./dsp-tools-xmlupload.md#groups), the membership of the users to the project specific groups
can be freely chosen by the `ProjectAdmin`. A project may define several groups such as "student-assistant",
"editors", etc. in order to provide their members specific permissions.
The groups that were created here are then available in the XML file in the
[&lt;permissions&gt; element](dsp-tools-xmlupload.md#permissions-element).

A project specific group definition has the following elements:

- _name_ (mandatory): name of the group
- _descriptions_ (mandatory): description of the group with language tags in the form `"descriptions": {"<lang>":
"<string>", ...}` (currently, "en", "de", "fr", "it", and "rm" are supported)
- _selfjoin_ (optional): true if users are allowed to join the group themselves, false (default) if a `ProjectAdmin` has
to add them
- _status_ (optional): true (default) if the group is active, false if the group is inactive

Example:

```json
{
"groups": [
{
"name": "biz-editors",
"descriptions": {"en" : "Editors for the BiZ project"},
"selfjoin": false,
"status": true
}
]
}
```

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if we should include this in the documentation as it is currently not supported by DSP-APP. Maybe we could at least add a sentence like "Groups are currently not supported by the DSP-APP. Therefore, it is discouraged to use groups."

docs/dsp-tools-xmlupload.md Outdated Show resolved Hide resolved
docs/dsp-tools-xmlupload.md Outdated Show resolved Hide resolved
docs/dsp-tools-xmlupload.md Outdated Show resolved Hide resolved
@jnussbaum jnussbaum merged commit 33ab59d into main Dec 20, 2022
@jnussbaum jnussbaum deleted the wip/dev-1561-docs-permissions branch December 20, 2022 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants