chore(xmlupload): add metrics flag (DEV-1512) #264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
other small improvements
BalduinLandolt
approved these changes
Dec 1, 2022
knora/dsplib/utils/xml_upload.py
Outdated
| @@ -26,6 +28,8 @@ | |||
| from knora.dsplib.models.xmlresource import XMLResource | |||
| from knora.dsplib.utils.shared import try_network_action, validate_xml_against_schema | |||
|
|
|||
| MetricRecord = namedtuple("MetricRecord", ["res_id", "filetype", "filesize_mb", "event", "duration_microsec", "mb_per_sec"]) | |||
There was a problem hiding this comment.
I like this pattern of using a data structure ("product type" in functional terminology) as a model for data in code. Personally I tend to implement this using dataclasses rather than namedtuples... but that's just a matter of taste.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves DEV-1512