Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(excel2xml): prevent writing empty text-prop, make text-prop validation less restrictive (DEV-1440) #243

Merged
merged 1 commit into from Oct 25, 2022
Merged

fix(excel2xml): prevent writing empty text-prop, make text-prop validation less restrictive (DEV-1440) #243

merged 1 commit into from Oct 25, 2022

Conversation

jnussbaum
Copy link
Collaborator

resolves DEV-1440

@jnussbaum jnussbaum self-assigned this Oct 22, 2022
@jnussbaum jnussbaum changed the title fix(excel2xml): prevent writing empty <text-prop>, make text prop validation less restrictive fix(excel2xml): prevent writing empty text-prop, make text-prop validation less restrictive Oct 22, 2022
BalduinLandolt
BalduinLandolt approved these changes Oct 24, 2022
View reviewed changes
Copy link
Collaborator

@BalduinLandolt BalduinLandolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

knora/excel2xml.py Show resolved Hide resolved
@jnussbaum jnussbaum changed the title fix(excel2xml): prevent writing empty text-prop, make text-prop validation less restrictive fix(excel2xml): prevent writing empty text-prop, make text-prop validation less restrictive (DEV-1440) Oct 25, 2022
@jnussbaum jnussbaum merged commit ae777e4 into main Oct 25, 2022
@jnussbaum jnussbaum deleted the wip/dev-1440-excel2xml-writes-empty-text-prop branch October 25, 2022 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BalduinLandolt BalduinLandolt BalduinLandolt approved these changes

@irinaschubert irinaschubert Awaiting requested review from irinaschubert

Assignees

@jnussbaum jnussbaum

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jnussbaum @BalduinLandolt