docs(xmlupload): improve examples, add documentation of geometry-prop JSON format #240
Conversation
Co-authored-by: irinaschubert <irina.schubert@dasch.swiss>
docs/dsp-tools-xmlupload.md
Outdated
| "status": "active", | ||
| "type": "circle", | ||
| "lineColor": "#ff1100", | ||
| "lineWidth": 5, | ||
| "points": [{"x":0.5,"y":0.3}], | ||
| "radius": {"x":0.1,"y":0.1} |
There was a problem hiding this comment.
still wondering if the circle shouldn't actually be an ellipsis?
There was a problem hiding this comment.
ah, I see now, this can be an ellipsis. But wouldn't it be simpler to define the ellipsis by the bounding rectangle? (like e.g. in paint, when you "drag" a box with the mouse, and it "fills" it with an ellipsis)
There was a problem hiding this comment.
No, I don't think that an ellipsis is possible. It's just that the creators of knora decided to define the radius as vector (x, y). It's a bit like the hypothenuse of a right-angled triangle. I added a comment line in the JSON example to make it more clear.
There was a problem hiding this comment.
ok, I understand, thanks for the explanation. Interesting design choice. ;-)
Then my point remains, that in my opinion it should be an ellipsis, not a circle... (but again, that's not scope of this PR, so let's just keep it in the back of our heads)
| - In the SALSAH data, there is also a key named `original_index` in the JSON format of all three shapes, but it doesn't | ||
| seem to have an influence on the shapes that TANGOH displays, so it can be omitted. |
There was a problem hiding this comment.
"doesn't seem to ..." probably doesn't sound very confidence-inspiring to users
There was a problem hiding this comment.
I know. I reverse-engineered this entire thing, and since dsp-tools is mostly internal, I decided to reflect my current state of knowledge.
jnussbaum
changed the title
jnussbaum
changed the title
resolves DEV-1404