feat(xmlupload): enable migration of resource creation date (DEV-1402) #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnussbaum
commented
Oct 10, 2022
irinaschubert
suggested changes
Oct 10, 2022
jnussbaum
commented
Oct 13, 2022
| @@ -63,7 +62,7 @@ def __str__(self) -> str: | |||
| Convert to string | |||
| :return: stringyfied error message | |||
| """ | |||
| return self._message + "\n\n" + format_exc() | |||
There was a problem hiding this comment.
I don't have a clue what format_exc() was good for in the past, but I know that it causes problems. It was the source of this strange behaviour that I already had in the past: when a BaseError occurs while testing, Python prints an infinitely long stacktrace full of riddles, and then crashes.
I found out that I can just remove format_exc()
jnussbaum
commented
Oct 13, 2022
jnussbaum
commented
Oct 13, 2022
jnussbaum
commented
Oct 13, 2022
jnussbaum
commented
Oct 13, 2022
jnussbaum
commented
Oct 13, 2022
jnussbaum
commented
Oct 13, 2022
jnussbaum
requested review from
irinaschubert and
BalduinLandolt
and removed request for
BalduinLandolt
jnussbaum
commented
Oct 13, 2022
irinaschubert
approved these changes
Oct 13, 2022
Co-authored-by: irinaschubert <irina.schubert@dasch.swiss>
irinaschubert
approved these changes
Oct 17, 2022
jnussbaum
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves DEV-1402