Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix release-please (DEV-1396) #234

Merged
merged 1 commit into from Oct 7, 2022

Conversation

jnussbaum
Copy link
Collaborator

resolves DEV-1396

@jnussbaum jnussbaum self-assigned this Oct 6, 2022
Comment on lines -14 to -21
refused:
# Do not release if tests failed
runs-on: ubuntu-latest
if: ${{ github.event.workflow_run.conclusion == 'failure'}}
steps:
- id: refused_step
run: exit 1

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since there are no more tests on main, they cannot be checked. (And it's also not necessary, because a PR cannot be merged without sucessful tests).

release-please:
if: github.event.pull_request.merged == true
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jnussbaum jnussbaum merged commit 3bd92d8 into main Oct 7, 2022
@jnussbaum jnussbaum deleted the wip/dev-1396-fix-release-please branch October 7, 2022 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant