fix: xml validation (DEV-1360) #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnussbaum
changed the title
jnussbaum
commented
Sep 23, 2022
|
|
||
| def test_get(self) -> None: | ||
|
|
||
| def test_create_lists(self) -> None: |
There was a problem hiding this comment.
This test is new
jnussbaum
commented
Sep 23, 2022
Comment on lines
-159
to
-169
| def test_excel_to_json_list(self) -> None: | ||
| excel_to_json_lists.excel2lists(excelfolder='testdata/lists_multilingual', | ||
| path_to_output_file='testdata/tmp/_lists-out.json') | ||
|
|
||
| def test_excel_to_json_resources(self) -> None: | ||
| excel2resources(excelfile='testdata/Resources.xlsx', | ||
| path_to_output_file='testdata/tmp/_out_resources.json') | ||
|
|
||
| def test_excel_to_json_properties(self) -> None: | ||
| excel2properties(excelfile='testdata/Properties.xlsx', | ||
| path_to_output_file='testdata/tmp/_out_properties.json') |
There was a problem hiding this comment.
I moved these three to the end, so that the file is ordered according the order in dsp_tools.py
jnussbaum
commented
Sep 23, 2022
| excel2properties(excelfile='testdata/Properties.xlsx', | ||
| path_to_output_file='testdata/tmp/_out_properties.json') | ||
| def test_validate_xml_against_schema(self) -> None: | ||
| self.assertTrue(validate_xml_against_schema(self.test_data_systematic_file)) |
jnussbaum
commented
Sep 23, 2022
Comment on lines
+112
to
+121
| def test_create_project(self) -> None: | ||
| result = create_project( | ||
| input_file=self.test_project_systematic_file, | ||
| server=self.server, | ||
| user_mail=self.user, | ||
| password="test", | ||
| verbose=True, | ||
| dump=False | ||
| ) | ||
| self.assertTrue(result) |
There was a problem hiding this comment.
moved here from further down, so that the order is according to dsp_tools.py
jnussbaum
commented
Sep 23, 2022
|
|
||
|
|
||
| def test_validate_project(self) -> None: | ||
| self.assertTrue(validate_project(self.test_project_systematic_file)) |
There was a problem hiding this comment.
Ideally, you would always test for the failure case too (even better, if you can test different failing scenarios).
BalduinLandolt
approved these changes
Sep 23, 2022
|
|
||
|
|
||
| def test_validate_project(self) -> None: | ||
| self.assertTrue(validate_project(self.test_project_systematic_file)) |
There was a problem hiding this comment.
Ideally, you would always test for the failure case too (even better, if you can test different failing scenarios).
| excel2properties(excelfile='testdata/Properties.xlsx', | ||
| path_to_output_file='testdata/tmp/_out_properties.json') | ||
| def test_validate_xml_against_schema(self) -> None: | ||
| self.assertTrue(validate_xml_against_schema(self.test_data_systematic_file)) |
irinaschubert
approved these changes
Sep 23, 2022
BalduinLandolt
approved these changes
Sep 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves DEV-1360