chore: tidy up excel2lists, excel2resources, excel2properties (DEV-1352) #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnussbaum
commented
Sep 16, 2022
| @@ -0,0 +1,54 @@ | |||
| import dataclasses | |||
There was a problem hiding this comment.
To make excel2xml.py at least a bit shorter, I moved this class here.
jnussbaum
commented
Sep 16, 2022
| @@ -236,30 +236,6 @@ def _make_json_lists_from_excel(excel_file_paths: list[str], verbose: bool = Fal | |||
| return finished_lists | |||
|
|
|||
|
|
|||
| def simplify_name(value: str) -> str: | |||
There was a problem hiding this comment.
moved to shared_methods.py
jnussbaum
commented
Sep 16, 2022
| return True | ||
|
|
||
|
|
||
| def prepare_dataframe(df: pd.DataFrame, required_columns: list[str], location_of_sheet: str) -> pd.DataFrame: |
There was a problem hiding this comment.
moved to shared_methods.py
jnussbaum
commented
Sep 16, 2022
| @@ -25,20 +27,100 @@ def tearDownClass(cls) -> None: | |||
| os.remove('testdata/tmp/' + file) | |||
| os.rmdir('testdata/tmp') | |||
|
|
|||
| def test_excel2jsonlist(self) -> None: | |||
|
|
|||
There was a problem hiding this comment.
These 3 tests are new
jnussbaum
commented
Sep 16, 2022
BalduinLandolt
approved these changes
Sep 19, 2022
irinaschubert
approved these changes
Sep 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves DEV-1352