feat: add module csv2xml to convert tabular data to DSP-XML (DEV-134) #219

jnussbaum · 2022-08-19T18:22:18Z

resolves DEV-134

test/unittests/test_excel2xml.py

knora/dsp_tools.py

knora/dsplib/models/value.py

test/e2e/test_tools.py

BalduinLandolt

Overall certainly a great improvement to DSP-Tools.

I ended up with quite a number of comments - but not all of them are equally relevant.
I understand if you don't want to drag out that PR forever, so feel free to apply/ignore as much as you feel is right. But I really don't think any file should be 2k+ lines, so I'd like to see that broken up, if possible.

docs/dsp-tools-excel2xml.md

docs/assets/templates/excel2xml_script.py

knora/dsplib/models/value.py

knora/excel2xml.py

test/unittests/test_excel2xml.py

irinaschubert

LGTM, I have the feeling that the module is very hard to use for a custom user who does not do this work regularly. But I guess you clarified the use and need of this module beforehand?

docs/assets/templates/excel2xml_onto.json

docs/dsp-tools-excel.md

knora/excel2xml.py

test/e2e/test_tools.py

use uuid instead of hash

Co-authored-by: irinaschubert <irina.schubert@dasch.swiss>

…rop() functions

jnussbaum added 3 commits August 18, 2022 18:30

tests: remove unused stuff

1f31f51

add csv2xml, write docs

4fb26c4

continue unittests

8fbc6a3

jnussbaum self-assigned this Aug 19, 2022

jnussbaum and others added 19 commits August 22, 2022 17:32

write unit test for find_date_in_string()

08061dd

improve docstring

b34329b

catch warnings instead of muting them

f2cf691

_check_and_prepare_values(): refactor, write docstring, write tests

bace4b3

add setUpClass and tearDownClass

6351c33

improve make_boolean_prop

c210c53

repair tests

91bda19

improve check_and_prepare_values and make_color_prop

e231c43

automatize test cases

31caa52

refactor tests

01558a6

add unittest for make_geometry_prop

0804ac9

edit

f9e3439

edit

35c12f5

edit

6f7d9da

edit

d6ef16b

Merge branch 'main' into wip/dev-134-csv2xml

11f3bfb

pipenv install regex, xlrd

dd4fc92

edit

6bc8607

edit

b2cca7d

jnussbaum marked this pull request as ready for review August 30, 2022 14:03

add test for docs/assets/templates/excel2xml_script.py

9ccd5a8