Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add isSequenceOf (DEV-746) #214

Merged
merged 22 commits into from Aug 16, 2022
Merged

feat: add isSequenceOf (DEV-746) #214

merged 22 commits into from Aug 16, 2022

Conversation

jnussbaum
Copy link
Collaborator

resolves DEV-746

@jnussbaum jnussbaum marked this pull request as draft August 11, 2022 06:22
@jnussbaum jnussbaum self-assigned this Aug 11, 2022
@jnussbaum jnussbaum marked this pull request as ready for review August 15, 2022 08:23
@jnussbaum
Copy link
Collaborator Author

@BalduinLandolt: This is now ready for review. It was a surprisingly low-effort task, I thought there would be more to do.
There is one decision that I took that I would like to double-check with you: In the schema and the docs, it is now prescribed that if a property has the object InvervalValue, it must have super hasSequenceBounds. This is because it doesn't make sense to me to have an interval value on another resource than an audio/video sequence. Is that correct?

@BalduinLandolt
Copy link
Collaborator

@jnussbaum this is certainly not how IntervalValue was intended when it was introduced in the API. But personally I don't know of many use cases either, so I don't really mind this restriction. We'll have to see if it needs to be changed in the future...

BalduinLandolt
BalduinLandolt approved these changes Aug 16, 2022
View reviewed changes
Copy link
Collaborator

@BalduinLandolt BalduinLandolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, I hope I didn't miss anything

docs/dsp-tools-create-ontologies.md Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Aug 16, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@jnussbaum jnussbaum merged commit 991d424 into main Aug 16, 2022
@jnussbaum jnussbaum deleted the wip/DEV-746-add-issequenceof branch August 16, 2022 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BalduinLandolt BalduinLandolt BalduinLandolt approved these changes

Assignees

@jnussbaum jnussbaum

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jnussbaum @BalduinLandolt