Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(xmlupload): implement <annotation>, <region>, and <link> tags (DEV-855) (#204) #204

Merged
merged 26 commits into from Jul 18, 2022
Merged

feat(xmlupload): implement <annotation>, <region>, and <link> tags (DEV-855) (#204) #204

merged 26 commits into from Jul 18, 2022

Conversation

jnussbaum
Copy link
Collaborator

resolves DEV-855

@jnussbaum jnussbaum self-assigned this Jul 4, 2022
@jnussbaum jnussbaum changed the title xmlupload: enable usage of built-ins Region, Annotation, and LinkObj (DEV-855) feat: enable usage of built-ins Region, Annotation, and LinkObj (DEV-855) Jul 4, 2022
@jnussbaum jnussbaum force-pushed the wip/dev-855-allow-importing-region-resource branch 2 times, most recently from 584cf55 to 97709c8 Compare July 8, 2022 13:33
@jnussbaum
make it possible to use knora-api:Region and knora-api:Annotation (wi…
9ae3809 
…th their respective cardinalities that are required), without subclassing them first in the onto file
@jnussbaum
improve print output at the end of xmlupload
fa5f6db
@jnussbaum
update docs
7ae7a1c
@jnussbaum
update testdata
cd7d256
@jnussbaum
update JSON schemas
aed4002
@jnussbaum
refactor XSD Schema
b78fc9a
@jnussbaum
improve code smells
68ac0cd
@jnussbaum
adapt test data
7dec1b0
@jnussbaum
adapt docs
5e1c19f
@jnussbaum
first attempt of testing builtins with XML Schema
823cd0d
@jnussbaum
remove old todos
ae7486a
@jnussbaum
update gitignore
8948758
@jnussbaum
adapt schema files and testdata
45ea573
@jnussbaum
xmlupload: parse the <annotation>, <region>, and <link> tags correctly
9c14f4a
@jnussbaum
fix pytest DeprecationWarning: invalid escape sequence \.
a295db3
@jnussbaum
adapt hardcoded expectations to new test data
daef3e9
@jnussbaum
cardinality of hasComment of Region is in fact 1-n
991c025
@jnussbaum
refactor
91d1c99
@jnussbaum jnussbaum force-pushed the wip/dev-855-allow-importing-region-resource branch from 97709c8 to 91d1c99 Compare July 8, 2022 14:04
@jnussbaum jnussbaum marked this pull request as ready for review July 8, 2022 14:40
BalduinLandolt
BalduinLandolt approved these changes Jul 11, 2022
View reviewed changes
Copy link
Collaborator

@BalduinLandolt BalduinLandolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just some minor notes from my side

docs/dsp-tools-create-ontologies.md Outdated Show resolved Hide resolved
docs/dsp-tools-create-ontologies.md Show resolved Hide resolved
docs/dsp-tools-xmlupload.md Outdated Show resolved Hide resolved
docs/dsp-tools-xmlupload.md Outdated Show resolved Hide resolved
docs/dsp-tools-xmlupload.md Show resolved Hide resolved
docs/dsp-tools-xmlupload.md Outdated Show resolved Hide resolved
docs/dsp-tools-xmlupload.md Outdated Show resolved Hide resolved
knora/dsplib/models/resource.py Show resolved Hide resolved
knora/dsplib/models/xmlproperty.py Show resolved Hide resolved
knora/dsplib/schemas/data.xsd Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Jul 18, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@jnussbaum jnussbaum changed the title feat: enable usage of built-ins Region, Annotation, and LinkObj (DEV-855) feat(xmlupload): implement <annotation>, <region>, and <link> tags (DEV-855) (#204) Jul 18, 2022
@jnussbaum jnussbaum merged commit 5044a9e into main Jul 18, 2022
@jnussbaum jnussbaum deleted the wip/dev-855-allow-importing-region-resource branch July 18, 2022 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BalduinLandolt BalduinLandolt BalduinLandolt approved these changes

@irinaschubert irinaschubert Awaiting requested review from irinaschubert

Assignees

@jnussbaum jnussbaum

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jnussbaum @BalduinLandolt