Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(xmlupload): better explanation of permissions (DEV-969) #196

Merged
merged 10 commits into from Jun 1, 2022

Conversation

jnussbaum
Copy link
Collaborator

resolves DEV-969

@jnussbaum jnussbaum self-assigned this May 31, 2022
Copy link

@irinaschubert irinaschubert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thanks.

docs/dsp-tools-xmlupload.md Outdated Show resolved Hide resolved

The following access rights are defined by the DSP platform which apply to either a resource or a field:
The following access rights are defined by the DSP platform:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"DSP platform" is actually "doppelt gemoppelt" because DSP already means DaSCH Service Platform... If you want to adjust that here (I suggest just using "DSP"), could you go through all of the documentation to see if there are more occurrences of that case?

- `M` _modifiy permission_: The user may modify the element, but may not delete it.
- `D` _delete permission_: The user is allowed to delete the element.
- `CR` _change right permission_: The user may change the permission of the element.
- (no right): If no permission is defined for a certain group of users, these users cannot view any resources/values.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding this makes it much clearer now!

docs/dsp-tools-xmlupload.md Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Jun 1, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@@ -437,6 +465,7 @@ Attributes:
- `permissions`: ID or a permission set (optional, but if omitted, very restricted default permissions apply)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@irinaschubert Here I am not certain what "ID or a permission set" means. I know only one possibility of adding a permission, but here it sounds if it were 2 possibilities...

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question, I don't know what this means. I would just use "ID" or "permission ID" or something.

@jnussbaum jnussbaum merged commit d3efde8 into main Jun 1, 2022
@jnussbaum jnussbaum deleted the wip/dev-969-better-explanation-of-permissions branch June 1, 2022 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants