Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update schema-files (DEV-449) #187

Merged
merged 5 commits into from Apr 28, 2022
Merged

chore: update schema-files (DEV-449) #187

merged 5 commits into from Apr 28, 2022

Conversation

gNahcab
Copy link
Contributor

@gNahcab gNahcab commented Apr 26, 2022 •
edited

resolves DEV-449

@gNahcab gNahcab requested a review from jnussbaum April 26, 2022 15:31
@gNahcab gNahcab changed the title Wip/dev 449 update json schema Wip/chore Apr 26, 2022
@gNahcab gNahcab marked this pull request as draft April 26, 2022 15:34
@gNahcab gNahcab changed the title Wip/chore chore: update schema-files (DEV-449) Apr 26, 2022
@gNahcab gNahcab marked this pull request as ready for review April 26, 2022 15:50
@gNahcab gNahcab requested review from jnussbaum and removed request for jnussbaum April 27, 2022 08:51
@gNahcab gNahcab self-assigned this Apr 27, 2022
@sonarcloud
Copy link

sonarcloud bot commented Apr 27, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

jnussbaum
jnussbaum reviewed Apr 28, 2022
View reviewed changes
knora/dsplib/schemas/ontology.json
@@ -1178,7 +1178,6 @@
"required": [
"shortcode",
"shortname",
"longname",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why should longname be optional? I think it's important to have it...

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jnussbaum that came from me. I saw this already some time ago and asked @gNahcab to adjust it. From the API side it's not mandatory: https://docs.dasch.swiss/DSP-API/03-apis/api-admin/projects/#create-a-new-project
I think it is good if DSP-TOOLS has the same restrictions as the API. Otherwise we need to maintain two different systems / logics which is much harder to keep up to date.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for explaining, Irina. I approved the PR, and you can merge, @gNahcab 👍

jnussbaum
jnussbaum approved these changes Apr 28, 2022
View reviewed changes
Copy link
Collaborator

@jnussbaum jnussbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

irinaschubert
irinaschubert approved these changes Apr 28, 2022
View reviewed changes
Copy link

@irinaschubert irinaschubert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gNahcab gNahcab merged commit 9a5a50b into main Apr 28, 2022
@gNahcab gNahcab deleted the wip/dev-449-update-json-schema branch April 28, 2022 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnussbaum jnussbaum jnussbaum approved these changes

@irinaschubert irinaschubert irinaschubert approved these changes

Assignees

@gNahcab gNahcab

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gNahcab @irinaschubert @jnussbaum