Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(xmlupload): support Baseclass MovingImageRepresentation #185

Merged
merged 2 commits into from Apr 26, 2022
Merged

feat(xmlupload): support Baseclass MovingImageRepresentation #185

merged 2 commits into from Apr 26, 2022

Conversation

jnussbaum
Copy link
Collaborator

resolves DEV-835

@jnussbaum jnussbaum self-assigned this Apr 26, 2022
irinaschubert
irinaschubert approved these changes Apr 26, 2022
View reviewed changes
Copy link

@irinaschubert irinaschubert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, there is no test, but I assume you've tested it manually?

@sonarcloud
Copy link

sonarcloud bot commented Apr 26, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@jnussbaum
Copy link
Collaborator Author

@irinaschubert: Yes, it's tested manually, and now there is also test data.

@jnussbaum jnussbaum merged commit 7ebf588 into main Apr 26, 2022
@jnussbaum jnussbaum deleted the wip/dev-835-add-MovingImageRepresentation branch April 26, 2022 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@irinaschubert irinaschubert irinaschubert approved these changes

Assignees

@jnussbaum jnussbaum

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jnussbaum @irinaschubert