chore: improve XML and JSON Schemas (DEV-449) #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnussbaum
changed the title
added 2 commits
April 25, 2022 16:18
…emas' into wip/dev-449-improve-xml-json-schemas
irinaschubert
approved these changes
Apr 25, 2022
knora/dsplib/schemas/data.xsd
Outdated
Comment on lines
203
to
212
| <!-- boolean value type | ||
| <xs:complexType name="boolean_type"> | ||
| <xs:sequence> | ||
| <xs:element name="text" type="xs:boolean" minOccurs="0" maxOccurs="1"/> | ||
| </xs:sequence> | ||
| <xs:attribute name="permissions" type="xs:NCName" use="required"/> | ||
| <xs:attribute name="comment" type="xs:string"/> | ||
| </xs:complexType> | ||
|
|
||
| </xs:complexType>--> |
There was a problem hiding this comment.
Can the commented out code be deleted?
There was a problem hiding this comment.
Yes, I'll delete it. Thanks for the review!
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves DEV-449