Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for external ontologies (dev-512) #170

Merged
merged 16 commits into from Apr 11, 2022

Conversation

irinaschubert
Copy link

@irinaschubert irinaschubert commented Mar 25, 2022

resolves DEV-512
resolves DEV-786

@irinaschubert irinaschubert self-assigned this Mar 25, 2022
@irinaschubert irinaschubert marked this pull request as ready for review April 6, 2022 16:04
Copy link
Collaborator

@BalduinLandolt BalduinLandolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, just some minor comments

docs/dsp-tools-create-ontologies.md Outdated Show resolved Hide resolved
knora/dsplib/models/helpers.py Show resolved Hide resolved
knora/dsplib/models/helpers.py Show resolved Hide resolved
knora/dsplib/models/helpers.py Outdated Show resolved Hide resolved
knora/dsplib/models/helpers.py Outdated Show resolved Hide resolved
@jnussbaum
Copy link
Collaborator

LGTM, just some comments. I also added the additional Jira Issue that you fixed in the comment field of the PR.

@jnussbaum jnussbaum self-requested a review April 7, 2022 19:26
knora/dsplib/models/helpers.py Show resolved Hide resolved
knora/dsplib/models/propertyclass.py Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Apr 11, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@irinaschubert irinaschubert merged commit ff36bc1 into main Apr 11, 2022
@irinaschubert irinaschubert deleted the wip/dev-512-add-support-for-external-ontologies branch April 11, 2022 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants