feat(xmlupload): allow circular references (DEV-577)

[jnussbaum]

resolves DEV-577

[EricSommerhalder]

I had some small comments but overall it looks fine to me.

[irinaschubert]

Thanks for the work!

I added quite a few commentaries / suggestions, feel free to take over whatever you see fit.

I would test the code with unit tests so you can be sure that the code does what you expect it to do. There should never be tests inside the code itself to test the logic of the code. This should be done in unit tests.

Regarding the error messages: In my opinion (and experience), if an error happens, it should be called "error" (not exception). I recommend to stick to the pattern/formulation of error messages we already have in dsp-tools.

Regarding the security issue about the http, I declared it as safe.

The code is very complex (see code smell warnings from sonar cloud). Do you see any way to improve that? Could you take apart some of the code and make it less complex?

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
7 Code Smells

No Coverage information
0.0% Duplication