New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add explanation how an Excel file for list creation must be structured (DEV-533) #159
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added some suggestions for improvements, but feel free to chose whatever you find the best option.
}, | ||
"nodes": [ | ||
{ | ||
"name": "first-subnode", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"name": "first-subnode", | |
"name": "first-node", |
"name": "first-subnode", | ||
"labels": { | ||
"de": "erster Listenknoten", | ||
"en": "first subnode" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"en": "first subnode" | |
"en": "first node of the list" |
}, | ||
{ | ||
"name": "coarse-sand", | ||
"name": "first-sublist", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In my view, it is confusing to use the term "sub-list". The node called "first-sublist" here is the actual list. I would suggest using "list" or "my-list" or something similar.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I understand, the contents of Excel column A are already nodes/sublists. The top-level list name is defined by the file name.
In every case, my test data behaves that way...
Co-authored-by: irinaschubert <irina.schubert@dasch.swiss>
- add xmlns - correct mistake
Kudos, SonarCloud Quality Gate passed! |
resolves DEV-533