Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: improve docs (DEV-450) #152

Merged
merged 7 commits into from Feb 17, 2022
Merged

docs: improve docs (DEV-450) #152

merged 7 commits into from Feb 17, 2022

Conversation

jnussbaum
Copy link
Collaborator

resolves DEV-450

@jnussbaum jnussbaum self-assigned this Feb 9, 2022
@jnussbaum jnussbaum requested review from BalduinLandolt and removed request for BalduinLandolt February 15, 2022 13:40
Copy link
Collaborator

@BalduinLandolt BalduinLandolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just see my note on the CHANGELOG.md, but apart from that it seems good to merge

### [1.8.1](https://www.github.com/dasch-swiss/dsp-tools/compare/v1.8.0...v1.8.1) (2022-01-11)
## [1.8.1](https://www.github.com/dasch-swiss/dsp-tools/compare/v1.8.0...v1.8.1) (2022-01-11)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the CHANGELOG.md is automatically created. So changing stuff here will lead to inconsistencies in the future, once more automatic stuff is added... I'd suggest not doing this, but it's up to you.
(In case you're wondering why sometimes the versions are h2 and sometimes they are h3: that's the difference between minor and patch releases.)

Comment on lines +5 to +20
h1 {
font-weight: bold;
padding-top: 50px;
}
h2 {
font-weight: bold;
padding-top: 50px;
}
h3 {
font-weight: bold;
padding-top: 50px;
}
h4 {
font-weight: bold;
padding-top: 50px;
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Notice that this might only affect the docs at https://dasch-swiss.github.io/dsp-tools/ . If you want it to take effect on docs.dasch.swiss, you may have to change things on the docs repo too. (I'm not sure though.)

@sonarcloud
Copy link

sonarcloud bot commented Feb 17, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@jnussbaum jnussbaum merged commit be5b69f into main Feb 17, 2022
@jnussbaum jnussbaum deleted the wip/dev-450-improve-docs branch February 17, 2022 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants