Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(xml-upload): print XML validation errors when xmlupload fails due to validation (DEV-387) #149

Merged
merged 2 commits into from Jan 28, 2022

Conversation

jnussbaum
Copy link
Collaborator

resolves DEV-387

@jnussbaum jnussbaum self-assigned this Jan 27, 2022
Copy link

@irinaschubert irinaschubert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, did you try it out?

@jnussbaum
Copy link
Collaborator Author

@irinaschubert: Now you were super fast, giving your review even before I asked for it :-)
Yes, I tried it out, and it works as intended.

@irinaschubert
Copy link

@irinaschubert: Now you were super fast, giving your review even before I asked for it :-) Yes, I tried it out, and it works as intended.

Ah, sorry! I got a message that I was added as reviewer.. So, I thought it was ready. Well, nevermind :) It looks good anyway.

@sonarcloud
Copy link

sonarcloud bot commented Jan 28, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@jnussbaum jnussbaum changed the title chore(xml-upload): print XML validation errors when xmlupload fails due to validation chore(xml-upload): print XML validation errors when xmlupload fails due to validation (DEV-387) Jan 28, 2022
@jnussbaum jnussbaum merged commit 03554c2 into main Jan 28, 2022
@jnussbaum jnussbaum deleted the wip/DEV-387-print-error-when-xml-validation-fails branch January 28, 2022 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants