Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(xmlupload): use custom IRIs created from salsah ARKs for XML upload (DEV-179) #147

Merged
merged 12 commits into from Jan 27, 2022
Merged

feat(xmlupload): use custom IRIs created from salsah ARKs for XML upload (DEV-179) #147

merged 12 commits into from Jan 27, 2022

Conversation

irinaschubert
Copy link

resolves DEV-179

@irinaschubert irinaschubert changed the title feat(xmlupload): Use custom IRIs created from salsah ARKs for XML upload (DEV-179) feat(xmlupload): use custom IRIs created from salsah ARKs for XML upload (DEV-179) Jan 18, 2022
@irinaschubert irinaschubert self-assigned this Jan 19, 2022
@irinaschubert irinaschubert marked this pull request as ready for review January 19, 2022 15:27
BalduinLandolt
BalduinLandolt approved these changes Jan 26, 2022
View reviewed changes
Copy link
Collaborator

@BalduinLandolt BalduinLandolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

knora/dsplib/schemas/data.xsd Show resolved Hide resolved
knora/dsplib/utils/xml_upload.py Outdated Show resolved Hide resolved
knora/dsplib/utils/xml_upload.py Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Jan 27, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@irinaschubert irinaschubert merged commit 873324a into main Jan 27, 2022
@irinaschubert irinaschubert deleted the wip/dev-179-add-ark-migration-from-salsah branch January 27, 2022 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BalduinLandolt BalduinLandolt BalduinLandolt approved these changes

@jnussbaum jnussbaum Awaiting requested review from jnussbaum

Assignees

@irinaschubert irinaschubert

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@irinaschubert @BalduinLandolt