Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(permissions): use permissions in xml upload (DEV-178) #127

Merged
merged 38 commits into from Dec 7, 2021
Merged

fix(permissions): use permissions in xml upload (DEV-178) #127

merged 38 commits into from Dec 7, 2021

Conversation

irinaschubert
Copy link

resolves DEV-178

@irinaschubert irinaschubert self-assigned this Nov 29, 2021
@irinaschubert irinaschubert changed the title Wip/dev 178 permissions in xml upload fix(permissions)!: Fix permissions in xml upload (DEV-178) Nov 29, 2021
@irinaschubert irinaschubert changed the title fix(permissions)!: Fix permissions in xml upload (DEV-178) fix!(permissions): Use permissions in xml upload (DEV-178) Nov 29, 2021
@irinaschubert irinaschubert changed the title fix!(permissions): Use permissions in xml upload (DEV-178) fix(permissions)!: use permissions in xml upload (DEV-178) Nov 29, 2021
irinaschubert added 22 commits November 29, 2021 13:28
update .gitignore
3d6b148
precise the use of username for CLI options
42045be
create testdata to test permissions
019c4b5
update xml_upload to handle optional permissions
5c26015
Merge branch 'main' into wip/dev-178-permissions-in-xml-upload
4680642
Add bitstream resources to tests
e709aff
use resource permissions for bitstream objects
0e74a47
remove duplicated code
f0d9cac
remove duplicated code
dfc6d56
update documentation
6a5bff1
Remove unused file knora.py
4903ba3
use images to test permissions
cb3453a
allow permissions attribute for bitstreams
8ada272
Refactor xml_upload.py
4c2bc8a
add bitstream to models
11ed561
update documentation
efcfe95
Rename Knora instances
d916c01
Update test data
1531eb6
Rename output labels
cf97802
refactor bitstream
9a6192e
add bitstream to bazel
3f29527
refactor resource, value and bitstream
81b332b
@irinaschubert irinaschubert changed the title fix(permissions)!: use permissions in xml upload (DEV-178) fix(permissions): use permissions in xml upload (DEV-178) Dec 1, 2021
@irinaschubert irinaschubert marked this pull request as ready for review December 6, 2021 16:53
BalduinLandolt
BalduinLandolt approved these changes Dec 6, 2021
View reviewed changes
Copy link
Collaborator

@BalduinLandolt BalduinLandolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

knora/dsplib/models/bitstream.py Show resolved Hide resolved
testdata/test-data.xml Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Dec 7, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@irinaschubert irinaschubert merged commit 4dad0ce into main Dec 7, 2021
@irinaschubert irinaschubert deleted the wip/dev-178-permissions-in-xml-upload branch December 7, 2021 07:34
This was referenced Dec 7, 2021
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BalduinLandolt BalduinLandolt BalduinLandolt approved these changes

Assignees

@irinaschubert irinaschubert

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@irinaschubert @BalduinLandolt