Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(schema): list root node needs a comments object (DEV-61) #122

Merged
merged 4 commits into from Nov 25, 2021
Merged

fix(schema): list root node needs a comments object (DEV-61) #122

merged 4 commits into from Nov 25, 2021

Conversation

jnussbaum
Copy link
Collaborator

resolves DEV-61

@sonarcloud
Copy link

sonarcloud bot commented Nov 25, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

irinaschubert
irinaschubert approved these changes Nov 25, 2021
View reviewed changes
Copy link

@irinaschubert irinaschubert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also updated the documentation and added a test case in the test ontology. Otherwise it looks good, thanks for your effort!

@jnussbaum jnussbaum merged commit 7bdc589 into main Nov 25, 2021
@jnussbaum jnussbaum deleted the wip/dev-61-list-root-node-needs-a-comments branch November 25, 2021 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@irinaschubert irinaschubert irinaschubert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jnussbaum @irinaschubert