Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(id-to-iri): extend xmlupload to allow references to existing resources (DEV-60) #108

Merged
merged 60 commits into from Nov 22, 2021
Merged

feat(id-to-iri): extend xmlupload to allow references to existing resources (DEV-60) #108

merged 60 commits into from Nov 22, 2021

Conversation

irinaschubert
Copy link

resolves DEV-60

@irinaschubert irinaschubert self-assigned this Oct 26, 2021
@irinaschubert irinaschubert changed the title feat(id2iri): extend xmlupload to allow references to existing resources feat(id2iri): extend xmlupload to allow references to existing resources (DEV-60) Oct 26, 2021
@irinaschubert irinaschubert changed the title feat(id2iri): extend xmlupload to allow references to existing resources (DEV-60) feat(idToIri): extend xmlupload to allow references to existing resources (DEV-60) Oct 26, 2021
@irinaschubert irinaschubert changed the title feat(idToIri): extend xmlupload to allow references to existing resources (DEV-60) feat(id-to-iri): extend xmlupload to allow references to existing resources (DEV-60) Oct 26, 2021
irinaschubert added 26 commits October 27, 2021 17:57
improve code structure
e8855bb
improve and activate user tests
db523fd
remove code smells in user tests
cc1fc80
remove remnants of id_to_iri feature
adc71fe
improve user test
a3a623e
fix typo in Makefile
600913b
Update test_user.py
dc23cf4
fix failing list tests
8ffbc5d
fix typo
c4199ff
add more comments to lists test data
b87a0e6
fix failing list node test
4409227
improve test_listnode
7b995fc
improve test_connection
172d947
improve test_group
d5ee2e4
improve test_ontology
5995ada
improve test_project
fdd556f
improve test_propertyclass
2807c6c
improve test_resource
89ce041
improve test_resourceclass
bb82135
improve test_tools
bf83733
move unit tests to separate folder
4935636
Update Makefile
20e41cb
update GitHub CI actions
10723ff
Update test.yml
f23fc79
fix code smells in test_langstring
9272bd1
fix failing GitHub action
6d612a2
@irinaschubert irinaschubert force-pushed the wip/dev-60-incremental-xmlupload branch from fc7a061 to 3de3635 Compare November 4, 2021 14:30
@irinaschubert irinaschubert mentioned this pull request Nov 17, 2021
Closed
@irinaschubert irinaschubert marked this pull request as ready for review November 22, 2021 08:55
BalduinLandolt
BalduinLandolt approved these changes Nov 22, 2021
View reviewed changes
Copy link
Collaborator

@BalduinLandolt BalduinLandolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, just some minor comments

docs/dsp-tools-usage.md Outdated Show resolved Hide resolved
docs/dsp-tools-usage.md Show resolved Hide resolved
docs/dsp-tools-xmlupload.md Outdated Show resolved Hide resolved
knora/dsp_tools.py Outdated Show resolved Hide resolved
knora/dsp_tools.py Show resolved Hide resolved
knora/dsplib/utils/id_to_iri.py Outdated Show resolved Hide resolved
knora/dsplib/utils/id_to_iri.py Outdated Show resolved Hide resolved
knora/dsplib/utils/xml_upload.py Outdated Show resolved Hide resolved
requirements.txt Show resolved Hide resolved
BalduinLandolt
BalduinLandolt approved these changes Nov 22, 2021
View reviewed changes
Copy link
Collaborator

@BalduinLandolt BalduinLandolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

knora/dsplib/utils/xml_upload.py Outdated Show resolved Hide resolved
@BalduinLandolt
Update knora/dsplib/utils/xml_upload.py
d76bdf7 
Co-authored-by: Balduin Landolt <33053745+BalduinLandolt@users.noreply.github.com>
@sonarcloud
Copy link

sonarcloud bot commented Nov 22, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@irinaschubert irinaschubert merged commit 40b01db into main Nov 22, 2021
@irinaschubert irinaschubert deleted the wip/dev-60-incremental-xmlupload branch November 22, 2021 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BalduinLandolt BalduinLandolt BalduinLandolt approved these changes

Assignees

@irinaschubert irinaschubert

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@irinaschubert @BalduinLandolt