fix(schema-documentation): update schemas and documentation (DEV-61) #105
Conversation
|
Hi @Vijeinath , in this PR I integrated the changes Stefan has reported. I updated the schemas too as there were quite some inconsistencies. As Balduin doesn't work this week, I thought you could have a look at it instead. |
knora/dsplib/schemas/ontology.json
Outdated
| }, | ||
| "ncname": { | ||
| "type": "string", | ||
| "pattern": "^[a-zA-Z0-9][a-zA-Z0-9_-]*$", |
There was a problem hiding this comment.
@irinaschubert According to https://www.w3.org/TR/xml11/#NT-NameStartChar, NCName is not allowed to start with a number (but with underscore). Would that be valid for the API?
There was a problem hiding this comment.
That's right, the pattern wasn't correct. I changed it according to your suggestions and I also added "." as allowed character.
knora/dsplib/schemas/ontology.json
Outdated
| @@ -59,7 +57,7 @@ | |||
| ] | |||
| }, | |||
| { | |||
| "pattern": "^([\\w-]*)?:(\\w+)$" | |||
| "pattern": "^([-\\w]*)?:(\\w+)$" | |||
There was a problem hiding this comment.
Would it make sense to create a definition for this pattern (like prefixedname)? It seems to be used quite often. Is it correct that the first group sometimes ends with * and sometimes with + ?
There was a problem hiding this comment.
Yes, good idea. I introduced prefixedname for this pattern and replaced its occurrences. I also unified the use of * and +.
knora/dsplib/schemas/ontology.json
Outdated
| "isPartOf", | ||
| "seqnum" | ||
| ] | ||
| }, | ||
| { | ||
| "pattern": "^(([\\w-]*)?:([\\w ]+))$" | ||
| "pattern": "^(([-\\w]*)?:([\\w ]+))$" |
There was a problem hiding this comment.
@irinaschubert white space correct here?
There was a problem hiding this comment.
No, it's not. I used prefixedname instead.
resolves DEV-61
resolves #43
resolves #38
resolves Pulldown/List issue for listValues --> only List allowed