Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permissions in XML import file required or optional? #103

Closed
musicEnfanthen opened this issue Sep 24, 2021 · 2 comments
Closed

Permissions in XML import file required or optional? #103

musicEnfanthen opened this issue Sep 24, 2021 · 2 comments
Assignees

Comments

@musicEnfanthen
Copy link

musicEnfanthen commented Sep 24, 2021

The docs for the XML upload say that the permissions on a resource are optional, see https://dasch-swiss.github.io/dsp-tools/dsp-tools-xmlupload/

However, the schema says that the permissions are required: Cf. https://github.com/dasch-swiss/dsp-tools/blob/main/knora/dsplib/schemas/data.xsd#L411

The same contradiction applies to the properties, eg. text, date, list... Docs say optional, schema says required: Cf. https://github.com/dasch-swiss/dsp-tools/blob/main/knora/dsplib/schemas/data.xsd#L61

@irinaschubert , which one is correct?

@irinaschubert irinaschubert self-assigned this Oct 4, 2021
@irinaschubert
Copy link

Hi @musicEnfanthen , thanks for reporting this inconsistency. We've just updated the permission handling in dsp-tools (see latest release v1.7.0). Permissions are optional in the XML file for the XML upload. If not explicitly provided, default permissions are applied (only project admin is able to view/edit/delete/remove resources). I hereby close this issue.

@musicEnfanthen
Copy link
Author

Thank you @irinaschubert for the fix in #127

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants