@@ -14,7 +14,7 @@
arrow_downward
+
diff --git a/src/app/project/list/list-item/list-item.component.spec.ts b/src/app/project/list/list-item/list-item.component.spec.ts
index e625843e8a..f25538defe 100644
--- a/src/app/project/list/list-item/list-item.component.spec.ts
+++ b/src/app/project/list/list-item/list-item.component.spec.ts
@@ -172,6 +172,70 @@ describe('ListItemComponent', () => {
expect(testHostComponent.listItem.list[0].labels).toEqual([{value: 'Tree List Node 0123', language: 'en'}]);
});
+ it('should update the view to show an inserted node', () => {
+ const dspConnSpy = TestBed.inject(DspApiConnectionToken);
+
+ (dspConnSpy.admin.listsEndpoint as jasmine.SpyObj
).getList.and.callFake(
+ () => {
+ const response = new ListResponse();
+ response.list.listinfo.id = 'http://rdfh.ch/lists/0001/otherTreeList';
+ response.list.listinfo.isRootNode = true;
+ response.list.listinfo.labels = [{value: 'Tree List Node Root', language: 'en'}];
+ response.list.children = [
+ {
+ comments: [],
+ labels: [{value: 'Tree List Node 01', language: 'en'}],
+ id: 'http://rdfh.ch/lists/0001/otherTreeList01',
+ children: [
+ {
+ comments: [],
+ labels: [{value: 'Tree List Node 03', language: 'en'}],
+ id: 'http://rdfh.ch/lists/0001/otherTreeList03',
+ children: []
+ }
+ ]
+ },
+ {
+ comments: [],
+ labels: [{value: 'Tree List Node 04 between node 01 and node 02', language: 'en'}],
+ id: 'http://rdfh.ch/lists/0001/otherTreeList04',
+ children: []
+ },
+ {
+ comments: [],
+ labels: [{value: 'Tree List Node 02', language: 'en'}],
+ id: 'http://rdfh.ch/lists/0001/otherTreeList02',
+ children: []
+ }
+ ];
+ return of(ApiResponseData.fromAjaxResponse({response} as AjaxResponse));
+ }
+ );
+
+ const listNodeOperation: ListNodeOperation = new ListNodeOperation();
+ listNodeOperation.listNode = {
+ children: undefined,
+ comments: [],
+ hasRootNode: 'http://rdfh.ch/lists/0001/otherTreeList',
+ id: 'http://rdfh.ch/lists/0001/otherTreeList04',
+ labels: [{value: 'Tree List Node 04 between node 01 and node 02', language: 'en'}],
+ position: 1
+ };
+
+ listNodeOperation.operation = 'insert';
+
+ testHostComponent.listItem.updateView(listNodeOperation);
+
+ expect(testHostComponent.listItem.list.length).toEqual(3);
+
+ expect(testHostComponent.listItem.list[1].labels).toEqual([{value: 'Tree List Node 04 between node 01 and node 02', language: 'en'}]);
+
+ expect(dspConnSpy.admin.listsEndpoint.getList).toHaveBeenCalledWith(testHostComponent.parentIri);
+
+ // getList is called twice because it is also called in ngOnInit
+ expect(dspConnSpy.admin.listsEndpoint.getList).toHaveBeenCalledTimes(2);
+ });
+
it('should update the view to remove a deleted node', () => {
const listNodeOperation: ListNodeOperation = new ListNodeOperation();
listNodeOperation.listNode = {
diff --git a/src/app/project/list/list-item/list-item.component.ts b/src/app/project/list/list-item/list-item.component.ts
index 2f8b0dc56f..e3a82d3812 100644
--- a/src/app/project/list/list-item/list-item.component.ts
+++ b/src/app/project/list/list-item/list-item.component.ts
@@ -3,6 +3,7 @@ import {
ApiResponseData,
ApiResponseError,
KnoraApiConnection,
+ ListChildNodeResponse,
ListNode,
ListResponse,
RepositionChildNodeRequest,
@@ -97,6 +98,25 @@ export class ListItemComponent implements OnInit {
}
break;
}
+ case 'insert': {
+ // get the corresponding list from the API again and reassign the local list with its response
+ this._dspApiConnection.admin.listsEndpoint.getList(this.parentIri).subscribe(
+ (result: ApiResponseData) => {
+ if (result.body instanceof ListResponse) {
+ this.list = result.body.list.children; // root node
+ } else {
+ this.list = result.body.node.children; // child node
+ }
+
+ // emit the updated list of children to the parent node
+ this.refreshChildren.emit(this.list);
+ },
+ (error: ApiResponseError) => {
+ this._errorHandler.showMessage(error);
+ }
+ );
+ break;
+ }
case 'update': {
// use the position from the response from DSP-API to find the correct node to update
this.list[data.listNode.position].labels = data.listNode.labels;
@@ -118,6 +138,7 @@ export class ListItemComponent implements OnInit {
repositionRequest.position = data.listNode.position;
// since we don't have any way to know the parent IRI from the ListItemForm component, we need to do the API call here
+ // --> TODO now we have the parent IRI within the ListItemForm component so we can move this logic there
this._dspApiConnection.admin.listsEndpoint.repositionChildNode(data.listNode.id, repositionRequest).subscribe(
(res: ApiResponseData) => {
this.list = res.body.node.children;