Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Onto editor 404 error (DEV-1355) #831

Merged
merged 4 commits into from Sep 23, 2022

Conversation

mdelez
Copy link
Collaborator

@mdelez mdelez commented Sep 21, 2022

resolves DEV-1355

@mdelez mdelez added the bug A bug fix label Sep 21, 2022
@mdelez mdelez self-assigned this Sep 21, 2022
@mdelez mdelez marked this pull request as ready for review September 22, 2022 08:30
Copy link
Collaborator

@mpro7 mpro7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to implement my suggestion.

@@ -618,7 +618,11 @@ export class OntologyComponent implements OnInit {
this._dspApiConnection.v2.onto.deleteResourceProperty(resProp).subscribe(
(response: OntologyMetadata) => {
this.loading = false;
this.resetOntology(this.ontologyIri);
// this.resetOntology(this.ontologyIri);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would remove it if not needed anymore.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

definitely, removed in 3b60ad2

@mdelez mdelez merged commit e7836a9 into main Sep 23, 2022
@mdelez mdelez deleted the wip/dev-1355-onto-editor-404-error branch September 23, 2022 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants