fix: make deactivated projects invisible for all except sysadmin (DEV-1261) #821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpro7
changed the title
mdelez
requested changes
Sep 13, 2022
| @@ -168,8 +168,8 @@ describe('OverviewComponent', () => { | |||
|
|
|||
| it('should populate project lists correctly', () => { | |||
|
|
|||
| expect(testHostComponent.overviewComp.userProjects.length).toEqual(1); | |||
| expect(testHostComponent.overviewComp.otherProjects.length).toEqual(7); | |||
| expect(testHostComponent.overviewComp.userProjects.length).toEqual(0); | |||
There was a problem hiding this comment.
Instead of doing this, I would suggest setting the status of the mocked anything project to true and then you don't need to change these numbers and you can ensure that the list of projects the user is a member of still works. You can set the status to true just after line 145.
There was a problem hiding this comment.
True that, but only in this test. In the other the number need to be changed. Well written and very easy to understand tests.
mdelez
approved these changes
Sep 13, 2022
mpro7
deleted the
DEV-1261-dsp-app-deactivated-projects-should-not-be-displayed-on-landing-page
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves DEV-1261