New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: rollbar fixes (DEV-1324) #817
Conversation
…calling .length on it
…es isn't found in the cache
@Vijeinath @mpro7 this isn't really something you guys can test but it just adds a bunch of checks for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but check my suggestion.
@@ -63,7 +63,7 @@ export class ResultsComponent { | |||
|
|||
onSelectionChange(res: FilteredResources) { | |||
this.selectedResources = res; | |||
this.resourceIri = this.selectedResources.resInfo[0].id; | |||
this.resourceIri = this.selectedResources.resInfo[0] ? this.selectedResources.resInfo[0].id : undefined; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this.resourceIri = this.selectedResources.resInfo[0] ? this.selectedResources.resInfo[0].id : undefined; | |
this.resourceIri = this.selectedResources.resInfo[0]?.id; |
Isn't it enough?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you are correct, changed in b53ec4f
resolves DEV-1324