fix(int-value): fix int-value validation (DEV-1277) #815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vijeinath
reviewed
Sep 6, 2022
| @@ -87,7 +87,7 @@ export class IntValueComponent extends BaseValueDirective implements OnInit, OnC | |||
|
|
|||
| const newIntValue = new CreateIntValue(); | |||
|
|
|||
| newIntValue.int = this.valueFormControl.value; | |||
| newIntValue.int = parseInt(this.valueFormControl.value, 10); | |||
There was a problem hiding this comment.
The 10 looks like a magic number to me. It would be more readable to do something like:
const DEFAULT_VALUE = 10
newIntValue.int = parseInt(this.valueFormControl.value, DEFAULT_VALUE);
There was a problem hiding this comment.
Yeah, it's technically optional but the linter complains. I've replaced in with a const in fea1417
Vijeinath
reviewed
Sep 6, 2022
| @@ -105,7 +105,7 @@ export class IntValueComponent extends BaseValueDirective implements OnInit, OnC | |||
|
|
|||
| updatedIntValue.id = this.displayValue.id; | |||
|
|
|||
| updatedIntValue.int = this.valueFormControl.value; | |||
| updatedIntValue.int = parseInt(this.valueFormControl.value, 10); | |||
Vijeinath
requested changes
Sep 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves DEV-1277