refactor(upload): use file extensions for valid file types instead of MIME types (DEV-1203) #808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # package-lock.json
|
@EricSommerhalder @domsteinbach I changed how we check if a file type is allowed. It now checks the file extension instead of the MIME type. I would be grateful if you could also test this on your end and make sure all the file uploads work. You don't actually need to create a resource instance for each file, just check if the upload works via the upload component when you create a new resource instance. Here are the test files: |
domsteinbach
requested changes
Aug 31, 2022
src/app/workspace/resource/representation/upload/upload.component.ts
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves DEV-1203