feat(video): add download button and overlay to video player (DEV-1151) #798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdelez
changed the title
mdelez
requested changes
Aug 16, 2022
| <mat-icon>more_vert</mat-icon> | ||
| </button> | ||
| <mat-menu #more="matMenu"> | ||
| <button mat-menu-item (click)="openVideoInNewTab(video['changingThisBreaksApplicationSecurity'])"> |
There was a problem hiding this comment.
I believe this will break in production.
You'll probably have to use the bypass methods provided by Angular.
We already have access to the file url via this.src.fileValue.fileUrl so you can just replace video['changingThisBreaksApplicationSecurity'] with that.
|
|
||
| this._http.get(pathToJson, requestOptions).subscribe( | ||
| res => { | ||
| console.log('a', res); |
There was a problem hiding this comment.
these console.logs can be removed
There was a problem hiding this comment.
fixed in b852777
| @@ -9,6 +9,24 @@ | |||
| (canplaythrough)="loadedVideo()"> | |||
| </video> | |||
|
|
|||
| <div class="video-overlay" *ngIf="!play && firstPlayed"> | |||
There was a problem hiding this comment.
The video overlay should only show when hovering over the video no matter if it's playing or not. The play button should appear if it's paused and vice versa.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves DEV-1151