Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style(file-representations): adjust styling of file representation components (DEV-1186) #797

Merged
merged 1 commit into from Aug 15, 2022
Merged

style(file-representations): adjust styling of file representation components (DEV-1186) #797

merged 1 commit into from Aug 15, 2022

Conversation

mdelez
Copy link
Collaborator

@mdelez mdelez commented Aug 12, 2022

resolves DEV-1186

@mdelez mdelez added the styling Update style; no production code change label Aug 12, 2022
@mdelez mdelez self-assigned this Aug 12, 2022
@mdelez mdelez marked this pull request as ready for review August 12, 2022 12:26
@mdelez
Copy link
Collaborator Author

mdelez commented Aug 12, 2022

This is a rough PR due to the need for ::ng-deep to match the designs. If anyone wants to try to find a way around using ::ng-deep, go ahead :)

EricSommerhalder
EricSommerhalder approved these changes Aug 15, 2022
View reviewed changes
Copy link
Contributor

@EricSommerhalder EricSommerhalder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me and looks good. As a general remark it seems weird/not very DRY to me to have so many very similar css files for each type of representation. Don't know a better solution though :)

@mdelez mdelez merged commit 18aa134 into main Aug 15, 2022
@mdelez mdelez deleted the wip/dev-1186-three-dot-menu-css branch August 15, 2022 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EricSommerhalder EricSommerhalder EricSommerhalder approved these changes

@Vijeinath Vijeinath Awaiting requested review from Vijeinath

@domsteinbach domsteinbach Awaiting requested review from domsteinbach

Assignees

@mdelez mdelez

Labels
styling Update style; no production code change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mdelez @EricSommerhalder