Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(audio): Make changes to audio component (DEV-1148) #796

Merged
merged 6 commits into from Aug 11, 2022
Merged

feat(audio): Make changes to audio component (DEV-1148) #796

merged 6 commits into from Aug 11, 2022

Conversation

EricSommerhalder
Copy link
Contributor

resolves DEV-1148

@EricSommerhalder EricSommerhalder marked this pull request as draft August 11, 2022 09:01
@EricSommerhalder EricSommerhalder changed the title Wip/dev 1148 audio component feat(audio): Make changes to audio component (DEV-1148) Aug 11, 2022
@EricSommerhalder EricSommerhalder marked this pull request as ready for review August 11, 2022 09:26
mdelez
mdelez approved these changes Aug 11, 2022
View reviewed changes
Copy link
Collaborator

@mdelez mdelez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works well, thanks :)

@EricSommerhalder EricSommerhalder merged commit 0cabfe3 into main Aug 11, 2022
@EricSommerhalder EricSommerhalder deleted the wip/dev-1148-audio-component branch August 11, 2022 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdelez mdelez mdelez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@EricSommerhalder @mdelez