Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(notification): Notifications only appearing for a split second (DEV-1093) #794

Merged
merged 1 commit into from Aug 10, 2022

Conversation

mdelez
Copy link
Collaborator

@mdelez mdelez commented Aug 9, 2022

resolves DEV-1093

@mdelez mdelez added the bug A bug fix label Aug 9, 2022
@mdelez mdelez self-assigned this Aug 9, 2022
@mdelez mdelez marked this pull request as ready for review August 10, 2022 06:42
Copy link
Contributor

@EricSommerhalder EricSommerhalder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm amazed how you kept overview with this complexity. Maybe in the future you can split these in two prs? LGTM though.

@mdelez mdelez merged commit 110039d into main Aug 10, 2022
@mdelez mdelez deleted the wip/dev-1093-snackbar-duration-fix branch August 10, 2022 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants