feat(projects): changes to nav bar (DEV-1101) #790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ordion. Only for signed out users for now until the onto editor is moved to the settings
Vijeinath
reviewed
Aug 9, 2022
Comment on lines
78
to
80
| hideTooltip(elem: HTMLElement): boolean { | ||
| return !(elem.scrollHeight > elem.clientHeight); | ||
| } |
There was a problem hiding this comment.
I would rename the function because it does not directly do something about tool tip. It compares the height of the elements. So I would use something like "compareHeights" or "checkHeights" or "checkElementHeight" etc.
There was a problem hiding this comment.
good point! done in 1b17e0b
Vijeinath
reviewed
Aug 9, 2022
src/app/project/project.component.ts
Outdated
Comment on lines
239
to
241
| hideTooltip(elem: HTMLElement): boolean { | ||
| return !(elem.scrollHeight > elem.clientHeight); | ||
| } |
There was a problem hiding this comment.
see above about renaming function
Vijeinath
requested changes
Aug 9, 2022
Vijeinath
approved these changes
Aug 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves DEV-1101