fix(property-form): App changes "salsah-gui:List" to "salsah-gui:Pulldown" (DEV-1089) #783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves DEV-1089
The property form currently calls the
replaceGuiElement()method any time a label or comment on a property is changed and sincesalsah-gui:Listis no longer supported in the app as of #643, theguiElementof ListValue object types was always changed tosalsah-gui:Pulldown. However, in the API (not specifically stated in the docs, see screenshot below), it's only possible to change theguiElementof a TextValue object type so we should only callreplaceGuiElement()if the property is a TextValue and theguiElementis different from it's initial value.screenshot from old Youtrack task:
