New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(overview): add overview and project tile components (DEV-984) #777
Conversation
…ton for sysadmins, add logic to redirect user to project dashboard if only member of one project
…s for project-tile
src/app/project/project.component.ts
Outdated
@@ -222,6 +222,11 @@ export class ProjectComponent implements OnInit { | |||
} | |||
} | |||
|
|||
// go to overview page |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because this comment refers to the function its more common to do the "/** [...] */" comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
true true, changed in 2832fce
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Just keep in mind that I have never implemented tests in angular.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect thanks
resolves DEV-984