Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(date-value-handler): Date value fix (DEV-392) #771

Merged
merged 1 commit into from Jun 27, 2022
Merged

fix(date-value-handler): Date value fix (DEV-392) #771

merged 1 commit into from Jun 27, 2022

Conversation

mdelez
Copy link
Collaborator

@mdelez mdelez commented Jun 27, 2022

resolves DEV-392

@mdelez
fix(date-value-handler): add some null checks to ensure component has…
5ffe4f2 
… everything it needs before trying to use a property
@mdelez mdelez added the bug A bug fix label Jun 27, 2022
@mdelez mdelez requested a review from Vijeinath June 27, 2022 09:37
@mdelez mdelez self-assigned this Jun 27, 2022
@mdelez mdelez marked this pull request as ready for review June 27, 2022 10:57
Vijeinath
Vijeinath approved these changes Jun 27, 2022
View reviewed changes
Copy link
Collaborator

@Vijeinath Vijeinath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mdelez mdelez merged commit 4076f3e into main Jun 27, 2022
@mdelez mdelez deleted the wip/dev-392-date-value-fix branch June 27, 2022 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vijeinath Vijeinath Vijeinath approved these changes

Assignees

@mdelez mdelez

Labels
bug A bug fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mdelez @Vijeinath