New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(project): proof of new project workflow concept (DEV-985) #760
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm really liking the new look of it all! Just a few remarks and change requests.
...p/project/beta/ontology-classes/ontology-class-instance/ontology-class-instance.component.ts
Outdated
Show resolved
Hide resolved
src/app/project/beta/ontology-classes/ontology-class-item/ontology-class-item.component.ts
Outdated
Show resolved
Hide resolved
|
||
<!-- add new resource instance if instance id is called "add" --> | ||
<div class="single-instance-form" *ngIf="instanceId && instanceId === 'add'"> | ||
<h3>Create new {{classId}} instance</h3> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be done a bit nicer so that only the class name is used in the sentence instead of the entire class id string
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure thing. This will be done in the next iteration. Because I have only the IRI here and I have to make an API request first etc.
if (this.instanceId) { | ||
// single instance | ||
|
||
if (this.instanceId === 'add') { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a better way to make this logic for showing the create new res class instance form? Having empty if statements that appear to do nothing at a glance is a bit confusing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In case of this.instanceId
we have two options: in case of "add" the create-resource-instance-form is displayed. In case of "real" resource instance IRI/ID the single instance will be displayed. I thought to implement this view in the next iteration.
Maybe there's a third option called "/conf" where a project admin can edit the resource class itself.
I see, the chosen name "instanceId" is really confusing. I'll think about a better setup and will replace in the next branch.
resolves DEV-985