chore(resource): display incoming links the same way as prop values (DEV-567) #747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kilchenmann
added
enhancement
Vijeinath
reviewed
May 19, 2022
| @@ -101,7 +101,7 @@ <h3 class="label mat-title"> | |||
| <!-- list of properties --> | |||
| <div *ngFor="let prop of resource.resProps; let last = last"> | |||
| <!-- show property; all in case of showAll === true or only the ones with prop.values --> | |||
| <div *ngIf="(showAllProps || ( prop.values && prop.values.length > 0 )) && ( | |||
| <div *ngIf="(showAllProps || ( prop.values && prop.values.length > 0 ) || (prop.propDef.id === hasIncomingLinkIri && incomingLinkResources.length > 0)) && ( | |||
There was a problem hiding this comment.
This is a long line for a *ngIf. Is it possible to move this into a function within the typescript file and give the function a meaningful name?
There was a problem hiding this comment.
yes I know. good idea with the method, but for now I'm not able to spend too much time on small improvements. We need the big features now 😉
Vijeinath
approved these changes
May 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves DEV-567