fix(ontology): unsupported property type was displayed wrong (DEV-936) #740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vijeinath
reviewed
May 16, 2022
Comment on lines
+147
to
+160
| // if the property is of type number, but sub property of SeqNum, | ||
| // select the correct default prop params | ||
| propType = (group.elements.find(i => | ||
| i.objectType === property.objectType | ||
| i.objectType === property.objectType && i.subPropOf === Constants.SeqNum | ||
| )); | ||
| } else if (property.objectType === Constants.IntValue && subProp === Constants.SeqNum) { | ||
| } else if (property.objectType === Constants.TextValue) { | ||
| // if the property is of type text value, we have to check the gui element | ||
| // to get the correct default prop params | ||
| propType = (group.elements.find(i => | ||
| i.objectType === property.objectType && i.subPropOf === Constants.SeqNum | ||
| i.guiEle === property.guiElement && i.objectType === property.objectType | ||
| )); | ||
| } else { | ||
| // in all other cases the gui-element resp. the subProp is not relevant | ||
| // because the object type is unique |
There was a problem hiding this comment.
Small observation: In line 139/140 you put the comment before the if structure and here after the if and else
There was a problem hiding this comment.
Good point. It's always the question, where to put the comment. Normally we put it outside the if statement. But in this long list of if, else if, else I thought it makes sense to have it inside.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves DEV-936