feat(error): add file representation error message (DEV-791) #729

kilchenmann · 2022-05-07T10:57:48Z

resolves DEV-791

…DEV-638)

* test(error): add tests * test(user): update tests * test(user): update tests * test(user): fix user form test

src/app/main/status/status.component.scss

src/app/workspace/resource/representation/representation.service.ts

src/app/workspace/resource/representation/still-image/still-image.component.ts

Vijeinath

Just minor stuff to correct. I like your good structured coding

src/app/main/status/status.component.ts

src/app/workspace/resource/representation/still-image/still-image.component.ts

Vijeinath

Good

kilchenmann added 8 commits May 4, 2022 16:34

fix(resource): show progress indicator until whole resource is loaded (…

e9d277b

…DEV-638)

Merge branch 'main' into wip/dev-791-representation-error-handler

f1fbcb6

refactor(message): delete message component

5bf7640

refactor(error): update error message

87ec154

refactor(error): update error message

5a5072e

refactor(admin): use app-error instead of app-message

7f744c0

chore(gh): merge wrong created branch into correct one (#728)

0510107

* test(error): add tests * test(user): update tests * test(user): update tests * test(user): fix user form test

feat(representation): error in case of missing still-image file

62d1b45

kilchenmann marked this pull request as draft May 7, 2022 10:57

kilchenmann self-assigned this May 7, 2022

kilchenmann added enhancement New feature or request styling Update style; no production code change labels May 7, 2022

kilchenmann added 18 commits May 9, 2022 10:27

feat(representation): new service to check if file exists

d6266c4

style(error): refactor style

4dfbf67

feat(representation): possibility to disable av-timeline

bc7b802

feat(representation): error handler document

300d0ff

feat(representation): error handler still-image

f671282

feat(representation): error handler moving-image

35cda33

refactor(representation): make lint happy

b88c2e8

Merge branch 'main' into wip/dev-791-representation-error-handler

c741e0e

style(representation): correct position of error message

2c0f895

style(still-image): update osd header design

9814967

style(still-image): update osd header design

4016538

test(representation): fix tests

d8dbfa8

chore(representation): prepare still-image error handler

bfa438e

Merge branch 'main' into wip/dev-791-representation-error-handler

9112994

style(status): resolve style issues

94ccb3e

fix(resource): resolve issue with loading res

b023649

feat(error): error message in representation handler

367d562

feat(representation): check if file exists

d2ee76b

refactor(representation): display error handler in still-image

cc4df60

kilchenmann requested a review from mdelez May 11, 2022 13:04

kilchenmann marked this pull request as ready for review May 11, 2022 13:04

mdelez reviewed May 11, 2022

View reviewed changes

src/app/main/status/status.component.scss Outdated Show resolved Hide resolved

src/app/workspace/resource/representation/representation.service.ts Outdated Show resolved Hide resolved

src/app/workspace/resource/representation/still-image/still-image.component.ts Show resolved Hide resolved

kilchenmann added 8 commits May 12, 2022 16:42

Merge branch 'main' into wip/dev-791-representation-error-handler

6b685a4

Merge branch 'main' into wip/dev-791-representation-error-handler

595bbb9

refactor: clean up code

9f000d3

Merge branch 'main' into wip/dev-791-representation-error-handler

5981427

Merge branch 'main' into wip/dev-791-representation-error-handler

6f3a0e2

style(status): resolve status position

66a2bae

refactor(representation): display error handler in still-image

2f7fbb4

fix(representation): check if whole still image exists

497c6cf

kilchenmann requested a review from Vijeinath May 17, 2022 12:01

style(representation): resolve responsive style issue

11a8521

kilchenmann requested a review from mdelez May 17, 2022 12:21

Merge branch 'main' into wip/dev-791-representation-error-handler

219e5c3

Vijeinath requested changes May 18, 2022

View reviewed changes

src/app/main/status/status.component.ts Outdated Show resolved Hide resolved

src/app/workspace/resource/representation/still-image/still-image.component.ts Outdated Show resolved Hide resolved

kilchenmann added 2 commits May 18, 2022 15:15

refactor: add space between if and bracket

20a4e77

refactor(representation): remove brackets

06ea3fe

kilchenmann requested a review from Vijeinath May 18, 2022 13:18

Vijeinath approved these changes May 18, 2022

View reviewed changes

kilchenmann merged commit 462771e into main May 18, 2022

kilchenmann deleted the wip/dev-791-representation-error-handler branch May 18, 2022 13:27

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(error): add file representation error message (DEV-791) #729

feat(error): add file representation error message (DEV-791) #729

kilchenmann commented May 7, 2022

Vijeinath left a comment

Vijeinath left a comment

feat(error): add file representation error message (DEV-791) #729

feat(error): add file representation error message (DEV-791) #729

Conversation

kilchenmann commented May 7, 2022

Vijeinath left a comment

Choose a reason for hiding this comment

Vijeinath left a comment

Choose a reason for hiding this comment