New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(message): use only one static error component (DEV-900) #727
Conversation
* test(error): add tests * test(user): update tests * test(user): update tests * test(user): fix user form test
@mdelez would it make sense to rename the error-component into status-component, because it's not only used for errors. But we can discuss it on Monday. |
maybe |
ok, then I rename it |
@mdelez the PR should be ready for review now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this! A few remarks but then it can be merged.
|
||
.image, | ||
.text { | ||
justify-self: stretch; | ||
align-self: stretch; | ||
box-sizing: border-box; | ||
padding: 24px; | ||
// padding: 24px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can this be removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
resolved in a3fdd23
this.success = true; | ||
|
||
// this.loading = false; | ||
this._notification.openSnackBar('You have successfully updated user\'s profile data.'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the user's profile data
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
resolved in a3fdd23
resolves DEV-900