fix(resource-instance-form): disable "next" button when form is not valid (DEV-803) #713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion has been entered to proceed to the second step
Screen.Recording.2022-04-13.at.10.38.40.mov@kilchenmann I also added a progress indicator to clarify that something is happening in the background after the user selects something. If you want to try on your end, I recommend throttling your internet speed in the dev tools. |
kilchenmann
reviewed
Apr 13, 2022
| <button mat-raised-button type="button" color="primary" | ||
| [disabled]="!selectResourceForm.valid || this.errorMessage" (click)="nextStep()" class="form-next"> | ||
| [disabled]="(!selectedProject || !selectedOntology || !selectedResourceClass || !selectResourceForm.valid) || this.errorMessage" (click)="nextStep()" class="form-next"> | ||
| <app-progress-indicator *ngIf="loading" [status]="0" class="next-progress"></app-progress-indicator> |
There was a problem hiding this comment.
Can you set the color of the progress-indicator to primary? Just add [color]="'primary'"
kilchenmann
approved these changes
Apr 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves DEV-803