Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: use constants from js-lib directly (DEV-799) #712

Merged
merged 3 commits into from Apr 12, 2022
Merged

refactor: use constants from js-lib directly (DEV-799) #712

merged 3 commits into from Apr 12, 2022

Conversation

kilchenmann
Copy link
Contributor

resolves DEV-799

@kilchenmann kilchenmann self-assigned this Apr 12, 2022
@kilchenmann kilchenmann marked this pull request as draft April 12, 2022 06:45
@kilchenmann kilchenmann added refactor Refactor or redesign dependencies Pull requests that update a dependency file labels Apr 12, 2022
@kilchenmann kilchenmann marked this pull request as ready for review April 12, 2022 07:38
Vijeinath
Vijeinath approved these changes Apr 12, 2022
View reviewed changes
Copy link
Collaborator

@Vijeinath Vijeinath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kilchenmann kilchenmann merged commit 374b5a8 into main Apr 12, 2022
@kilchenmann kilchenmann deleted the wip/dev-799-bump-js-lib branch April 12, 2022 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vijeinath Vijeinath Vijeinath approved these changes

@mdelez mdelez Awaiting requested review from mdelez

Assignees

@kilchenmann kilchenmann

Labels
dependencies Pull requests that update a dependency file refactor Refactor or redesign
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kilchenmann @Vijeinath