feat(representation): implement video player incl. preview (DEV-701) #698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdelez
requested changes
Apr 21, 2022
| ); | ||
|
|
||
| dialogRef.afterClosed().subscribe((data) => { | ||
| this._replaceFile(data); |
There was a problem hiding this comment.
We should check if data is undefined here, otherwise it breaks the video player. This is my fault actually and should be changed in each openReplaceFileDialog that I added in #695. Interestingly this didn't cause an issue with the other openReplaceFileDialog methods which is why I didn't catch it. Should I open a separate PR for this once this is merged?
There was a problem hiding this comment.
We should do it in a separate task.
I can disable the "replace-file" button in this task to avoid crashing player.
There was a problem hiding this comment.
resolved in a6527d4
src/app/workspace/resource/representation/video/video-preview/video-preview.component.scss
Outdated
Show resolved
Hide resolved
src/app/workspace/resource/representation/video/video-preview/video-preview.component.scss
Outdated
Show resolved
Hide resolved
src/app/workspace/resource/representation/video/video-preview/video-preview.component.ts
Outdated
Show resolved
Hide resolved
src/app/workspace/resource/representation/video/video.component.ts
Outdated
Show resolved
Hide resolved
|
Thank you @mdelez 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves DEV-701 and DEV-26