Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: clean up code, tests and packages #694

Merged
merged 5 commits into from Mar 23, 2022
Merged

refactor: clean up code, tests and packages #694

merged 5 commits into from Mar 23, 2022

Conversation

kilchenmann
Copy link
Contributor

@kilchenmann kilchenmann commented Mar 23, 2022 •
edited

I had to exclude a test that was causing problems in Github Actions. I also cleaned up the workflow and updated dependent packages.

@kilchenmann kilchenmann self-assigned this Mar 23, 2022
@kilchenmann kilchenmann added refactor Refactor or redesign testing All about tests: adding, refactoring tests; no production code change dependencies Pull requests that update a dependency file labels Mar 23, 2022
@kilchenmann kilchenmann requested a review from mdelez March 23, 2022 14:39
mdelez
mdelez approved these changes Mar 23, 2022
View reviewed changes
Copy link
Collaborator

@mdelez mdelez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@kilchenmann kilchenmann merged commit 1ad0879 into main Mar 23, 2022
@kilchenmann kilchenmann deleted the wip/test-fixes branch March 23, 2022 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdelez mdelez mdelez approved these changes

Assignees

@kilchenmann kilchenmann

Labels
dependencies Pull requests that update a dependency file refactor Refactor or redesign testing All about tests: adding, refactoring tests; no production code change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kilchenmann @mdelez